This is a bug report for perl from lionel.cons@cern.ch,
generated with the help of perlbug 1.26 running under perl 5.00503.


-----------------------------------------------------------------
[Please enter your report here]

timelocal does not handle correctly dates close to DST changes.
The included program tests T == timelocal(localtime(T)) for
some values of T.

  use Time::Local;
  
  sub test {
      my($time) = @_;
      my(@local, $test);
  
      printf("testing %d [%s]\n", $time, scalar(localtime($time)));
      @local = localtime($time);
      $test = timelocal(@local);
      printf("timelocal %d %s\n", $test, $test == $time ? "ok" : "not ok");
  }
  
  $time = 1004226198;
  
  foreach (1 .. 10) {
      test($time);
      $time += 300;
  }

and here is the output:

testing 1004226198 [Sun Oct 28 01:43:18 2001]
timelocal 1004226198 ok
testing 1004226498 [Sun Oct 28 01:48:18 2001]
timelocal 1004226498 ok
testing 1004226798 [Sun Oct 28 01:53:18 2001]
timelocal 1004226798 ok
testing 1004227098 [Sun Oct 28 01:58:18 2001]
timelocal 1004227098 ok
testing 1004227398 [Sun Oct 28 02:03:18 2001]
timelocal 1004230998 not ok
testing 1004227698 [Sun Oct 28 02:08:18 2001]
timelocal 1004231298 not ok
testing 1004227998 [Sun Oct 28 02:13:18 2001]
timelocal 1004231598 not ok
testing 1004228298 [Sun Oct 28 02:18:18 2001]
timelocal 1004231898 not ok
testing 1004228598 [Sun Oct 28 02:23:18 2001]
timelocal 1004232198 not ok
testing 1004228898 [Sun Oct 28 02:28:18 2001]
timelocal 1004232498 not ok

[Please do not change anything below this line]
-----------------------------------------------------------------

---
Site configuration information for perl 5.00503:

Configured by root at Thu Aug 10 15:31:56 EDT 2000.

Summary of my perl5 (5.0 patchlevel 5 subversion 3) configuration:
  Platform:
    osname=linux, osvers=2.2.5-22smp, archname=i386-linux
    uname='linux porky.devel.redhat.com 2.2.5-22smp #1 smp wed jun 2 09:11:51 edt 1999 i686 unknown '
    hint=recommended, useposix=true, d_sigaction=define
    usethreads=undef useperlio=undef d_sfio=undef
  Compiler:
    cc='cc', optimize='-O2 -m486 -fno-strength-reduce', gccversion=egcs-2.91.66 19990314/Linux (egcs-1.1.2 release)
    cppflags='-Dbool=char -DHAS_BOOL -I/usr/local/include'
    ccflags ='-Dbool=char -DHAS_BOOL -I/usr/local/include'
    stdchar='char', d_stdstdio=undef, usevfork=false
    intsize=4, longsize=4, ptrsize=4, doublesize=8
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12
    alignbytes=4, usemymalloc=n, prototype=define
  Linker and Libraries:
    ld='cc', ldflags =' -L/usr/local/lib'
    libpth=/usr/local/lib /lib /usr/lib
    libs=-lnsl -ldl -lm -lc -lposix -lcrypt
    libc=, so=so, useshrplib=false, libperl=libperl.a
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-rdynamic'
    cccdlflags='-fpic', lddlflags='-shared -L/usr/local/lib'

Locally applied patches:
    

---
@INC for perl 5.00503:
    /afs/cern.ch/user/c/cons/public/perl/lib
    /usr/lib/perl5/5.00503/i386-linux
    /usr/lib/perl5/5.00503
    /usr/lib/perl5/site_perl/5.005/i386-linux
    /usr/lib/perl5/site_perl/5.005
    .

---
Environment for perl 5.00503:
    HOME=/afs/cern.ch/user/c/cons
    LANG=en_US
    LANGUAGE (unset)
    LC_ALL=en_US
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/afs/cern.ch/user/c/cons/bin:/afs/cern.ch/user/c/cons/scripts:/afs/cern.ch/user/c/cons/bin:/afs/cern.ch/user/c/cons/scripts:/usr/sue/bin:/usr/local/bin:/bin:/usr/bin:/usr/X11R6/bin:/usr/afsws/bin:/usr/bin/X11:/usr/local/bin/X11:/usr/X11R6/bin
    PERLLIB=/afs/cern.ch/user/c/cons/public/perl/lib
    PERL_BADLANG (unset)
    SHELL=/bin/tcsh 

On Wed, Oct 24, 2001 at 02:56:23PM +0200, Lionel CONS wrote:
> @_MonthDays = qw(0 31 59 90 120 151 181 212 243 273 304 334);

Silly question... where are you accounting for leap years?


-- 

Michael G. Schwern   <schwern@pobox.com>    http://www.pobox.com/~schwern/
Perl6 Quality Assurance     <perl-qa@perl.org>	     Kwalitee Is Job One
Milk is timeless. 

Michael G Schwern writes:
 > On Wed, Oct 24, 2001 at 02:56:23PM +0200, Lionel CONS wrote:
 > > @_MonthDays = qw(0 31 59 90 120 151 181 212 243 273 304 334);
 > 
 > Silly question... where are you accounting for leap years?

I don't need to...

@_MonthDays is only used to get closer to the real date and the while
loop will take care of the rest.

__________________________________________________________
Lionel Cons        http://cern.ch/lionel.cons
CERN               http://www.cern.ch
 
If at first you don't succeed, destroy all evidence that you tried. 

Michael G Schwern wrote:
> 
> On Wed, Oct 24, 2001 at 02:56:23PM +0200, Lionel CONS wrote:
> > @_MonthDays = qw(0 31 59 90 120 151 181 212 243 273 304 334);
> 
> Silly question... where are you accounting for leap years?

In two places: "if ($offset == 0 " and " * 31557600; # * 365.25 days"

-- 
Klein bottle for rent - inquire within. 

Could I get a patch against the bleadperl version of lib/Time/Local.pm
and its test, lib/Time/Local.t?

-- 
$jhi++; # http://www.iki.fi/jhi/
        # There is this special biologist word we use for 'stable'.
        # It is 'dead'. -- Jack Cohen 

On Thu, Oct 25, 2001 at 04:39:58PM +0300, Jarkko Hietaniemi wrote:
> Could I get a patch against the bleadperl version of lib/Time/Local.pm
> and its test, lib/Time/Local.t?

Lionel and I are still working out the kinks off-list.


-- 

Michael G. Schwern   <schwern@pobox.com>    http://www.pobox.com/~schwern/
Perl6 Quality Assurance     <perl-qa@perl.org>	     Kwalitee Is Job One
conway: unit of mind expansion.  One Conway == ~20 lines of Perl code
  found in $CPAN/authors/id/D/DC/DCONWAY, which gives the sensation
  of your brain being wrapped around a brick, with kiwi juice squeezed
  on top.
	-- Ziggy