This is the mail archive of the
gnats-devel@sources.redhat.com
mailing list for the GNATS project.
PATCH: gnatsweb and cookie-detection JavaScript
- To: <gnats-devel at sources dot redhat dot com>
- Subject: PATCH: gnatsweb and cookie-detection JavaScript
- From: Gerald Pfeifer <pfeifer at dbai dot tuwien dot ac dot at>
- Date: Sat, 24 Mar 2001 01:14:26 +0100 (CET)
I installed the following patch which I had developed for and deployed
on gcc.gnu.org a couple of weeks ago.
Gerald
2001-03-24 Gerald Pfeifer <pfeifer@dbai.tuwien.ac.at>
* gnatsweb.pl (login_page_javascript): Use correct <SCRIPT LANGUAGE>.
Fix the Javascript code and improve the warning messages if cookies
are not enabled.
Index: gnatsweb.pl
===================================================================
RCS file: /cvs/gnats/gnats/contrib/gnatsweb/gnatsweb.pl,v
retrieving revision 2.27
diff -u -3 -p -r2.27 gnatsweb.pl
--- gnatsweb.pl 2001/03/21 09:09:27 2.27
+++ gnatsweb.pl 2001/03/24 00:11:26
@@ -2799,7 +2799,7 @@ sub praddr
sub login_page_javascript
{
my $ret = q{
-<SCRIPT LANGUAGE="JavaScript1.2" TYPE="text/javascript">
+<SCRIPT LANGUAGE="JavaScript" TYPE="text/javascript">
//<!--
// JavaScript courtesy of webcoder.com.
@@ -2833,10 +2833,11 @@ setCookie("gnatsweb-test-cookie", "whate
val = getCookie("gnatsweb-test-cookie");
delCookie("gnatsweb-test-cookie");
if (val == null) {
- document.write("<h2>Warning: your browser is not accepting cookies</h2>"
- ."<p>Unfortunately, Gnatsweb requires cookies to keep track of your "
- ."login and other information. "
- ."Please enable cookies before logging in.</p>");
+ document.write(
+ "<p><strong>Warning: your browser is not accepting cookies!</strong> "
+ +"Unfortunately, Gnatsweb requires cookies to keep track of your "
+ +"login and other information. "
+ +"Please enable cookies before logging in.</p>");
}
//-->