This is the mail archive of the gnats-devel@sources.redhat.com mailing list for the GNATS project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

PATCH: Long paragraphs are lost during PR edits


Gnats 3.113 has a nasty bug where, when you edit a PR containing text 
paragraphs of more than 512 characters, these paragraphs are discarded by 
gnatsd. They simply vanish from the PR.

This is caused by the #define MAXLINE 512 in gnats/query.h

I have increased this to 16384 (16kB), and the problem disappeared. The 
following patch against the tip of the v3 branch does this:

2001-04-30  Yngve Svendsen <yngve.svendsen@clustra.com>

     * query.h: Increase MAXLINE to 16384


Index: query.h
===================================================================
RCS file: /cvs/gnats/gnats/gnats/query.h,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 query.h
--- query.h     1998/11/05 19:54:10     1.1.1.1
+++ query.h     2001/04/30 15:09:47
@@ -42,7 +42,7 @@ Software Foundation, 59 Temple Place - S
  /* Query the gnats config file.  */
  #define LIST_CONFIG (1<<6)

-#define MAXLINE 512
+#define MAXLINE 16384

  /* How we should print out the format of the PR.  */
  extern unsigned int query_format;


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]